-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation-related fixes to the python client #3663
Conversation
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3663-all-demos |
Although still need to add tests and fix old tests, I'd appreciate a review for feedback on this documentation format and approach for getting the documentation. cc @aliabd -- I was able to get all of the documentation entirely from the backend. I think we can remove the documentation from the frontend and use this instead. |
Synced with @freddyaboulton, I'll make some changes to this PR before opening it for reivew |
@freddyaboulton after our discussion, made the following changes:
For now, the only component that overrides the serializer info is the Adding some tests and then will open this up for review |
Opening this up for review (Note that GitHub actions is currently down, but ci.sh can be run locally) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid PR @abidlabs ! Implementation looks good to me. Left some comments but nothing major. Thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abidlabs Thanks for making the changes! This looks great. I guess we need to release to PyPi to fix the CI? Feel free to merge once CI is green - landing soonish.
Thanks @freddyaboulton for the great suggestions! Yup still doing some more tweaks to get the machine readable part working, but I'll release to pypi once everything is working |
All righty, did some more cleanup, now we have a machine-parsable info, everything is passing, and docs looks pretty nice imo. Will release a new version of the client to pypi, and then merge once CI passes. |
Lots of little annoying fixes, but we should be there soon (cc @aliabd) |
Thanks for the review @freddyaboulton, finally in! |
This PR:
Client
class and methods, clarifies that callbacks are executed sequentiallywhich produces:
You can also get the API in a machine-friendly way by simply doing
client.view_api(return_info=True)
, so this closes #2364In order to get this info programmatically, I expanded the set of Serializers.
Related: #3565