Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add params to getDescendants #796

Merged
merged 4 commits into from
Jun 17, 2024
Merged

fix: add params to getDescendants #796

merged 4 commits into from
Jun 17, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 17, 2024 •
edited
Loading

fix #795

@spaenleh spaenleh requested review from pyphilia and ReidyT June 17, 2024 09:03
@spaenleh spaenleh self-assigned this Jun 17, 2024
@spaenleh spaenleh added improvement Not a feature but a QoL improvement in DX feature New feature or request and removed improvement Not a feature but a QoL improvement in DX labels Jun 17, 2024
@spaenleh spaenleh mentioned this pull request Jun 17, 2024
Merged
pyphilia
pyphilia approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🐟

src/api/item.test.ts Outdated Show resolved Hide resolved
src/api/item.test.ts Outdated Show resolved Hide resolved
src/api/item.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
13.5% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh enabled auto-merge June 17, 2024 13:01
@spaenleh spaenleh added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit f7becea Jun 17, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Merged
@spaenleh spaenleh deleted the 795-update-get-descendants branch June 17, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT Awaiting requested review from ReidyT

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@spaenleh spaenleh

Labels
feature New feature or request v3.13.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getDescendants parameters to include new itemTypes and showHidden
2 participants
@spaenleh @pyphilia