Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add container and header for folders #640

Merged
merged 12 commits into from
Apr 29, 2024
Merged

feat: add container and header for folders #640

merged 12 commits into from
Apr 29, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Apr 25, 2024 •
edited
Loading

Screenshot 2024-04-26 at 16 15 46

fix loading descendants shows nothing

@spaenleh spaenleh self-assigned this Apr 25, 2024
@spaenleh spaenleh added the feature New feature or request label Apr 25, 2024
pyphilia
pyphilia approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as we've discussed, as soon as you merge people won't be able to change the display name of all items (except documents). Is builder ready for this change?

package.json Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member Author

@pyphilia I reverted the use of displayName in almost all places outside of the collapse and document.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 91b45e1 Apr 29, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Merged
@spaenleh spaenleh deleted the add-container branch April 29, 2024 08:43
This was referenced Apr 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinaYahya LinaYahya LinaYahya approved these changes

@pyphilia pyphilia pyphilia approved these changes

@mariembencheikh mariembencheikh Awaiting requested review from mariembencheikh

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
feature New feature or request v2.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @LinaYahya