Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use thumbnails and display date on cards #498

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 2, 2024

In this PR:

  • upgrade deps
    • AUTH has been removed from translations
  • Display Thumbnails on home
  • Add last updated date as subtext
  • Fix grid on small screens

Here is a before/after view:

image

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good! How do you decide the colors or the logo?

@spaenleh
Copy link
Member Author

spaenleh commented Feb 5, 2024

@pyphilia The logos are just images I had on hand, my changes only allow to display the thumbnail (if there is one).
Do you think we should change the default folder icon be a different colour based on the the name of the item ? Would that make the player a bit more joyful ?

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit 1caa453 into main Feb 5, 2024
4 checks passed
@spaenleh spaenleh deleted the improve-home-card-grid branch February 5, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants