Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return all children for navigation #480

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: return all children for navigation #480

merged 2 commits into from
Jan 19, 2024

Conversation

pyphilia
Copy link
Contributor

close #478

@pyphilia pyphilia self-assigned this Jan 19, 2024
@pyphilia pyphilia marked this pull request as ready for review January 19, 2024 16:39
@pyphilia pyphilia mentioned this pull request Jan 19, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

55.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@pyphilia pyphilia merged commit 78e38ad into main Jan 19, 2024
3 of 4 checks passed
@pyphilia pyphilia deleted the 478-navigation-childrenorder branch January 19, 2024 17:03
@github-actions github-actions bot mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@pyphilia pyphilia

Labels
v2.4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

navigation does not show children outside of childrenOrder
3 participants
@pyphilia @spaenleh @ReidyT