Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workflows #152

Merged
merged 6 commits into from
Nov 14, 2022
Merged

feat: update workflows #152

merged 6 commits into from
Nov 14, 2022

Conversation

spaenleh
Copy link
Member

This PR updates the workflows and uses the new cypress re-usable workflow.

It also sets the document.domain to use the same origin trick with apps to let them resize the iframe.

closes #148

@spaenleh spaenleh added the chore Generic task or chore label Nov 11, 2022
@spaenleh spaenleh self-assigned this Nov 11, 2022
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests didn't really like it?

@spaenleh
Copy link
Member Author

@pyphilia there is a problem with the type-checking step, i should skip it. And i will investigate why this fails 😁

@spaenleh spaenleh merged commit f7942bd into main Nov 14, 2022
@spaenleh spaenleh deleted the 148-update-cypress-workflows branch November 14, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Generic task or chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cypress Workflow
2 participants