Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use params in descendants #755

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix: use params in descendants #755

merged 3 commits into from
Jun 17, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jun 17, 2024 •
edited
Loading

relies on graasp/graasp-query-client#796
Backend has already been merged.

In this PR I:

  • remove the itemContext because
    • we did not use it for the focusedItem since the move to the double id in the route
    • we did not use the descendants that were provided there
    • we did use the rootItem only in a single place (the new return button)
  • filtered the descendants to only include folder elements for the tree and previous next buttons as well as chatbot (to decide if we show the button in case a child has the chat enabled)

Warning

There is still an issue with the pinned items ... they fetch all descendants to know if the pinned button should be displayed. I a not sure how to handle this.

@spaenleh spaenleh requested review from pyphilia and ReidyT and removed request for ReidyT June 17, 2024 09:51
@spaenleh spaenleh self-assigned this Jun 17, 2024
@spaenleh spaenleh requested a review from LinaYahya June 17, 2024 10:03
pyphilia
pyphilia approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦮

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 479a029 Jun 17, 2024
4 checks passed
@graasper graasper mentioned this pull request Jun 17, 2024
Merged
@spaenleh spaenleh mentioned this pull request Jun 18, 2024
Closed
spaenleh added a commit that referenced this pull request Jun 21, 2024
@spaenleh
fix: use params in descendants (#755)
7002711 
* fix: use params in descendants

* chore: update dependency query-client

* fix: do not fetch all descendants to check the pinned items
@spaenleh spaenleh deleted the use-descendants-params branch June 26, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@spaenleh spaenleh

Labels
improvement v2.15.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia