Use DISCO APi for getting latest Mandrel releases #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to test similar to the GraalVM one for the expected error output.
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@fniephaus I went with a mandrel specific patch for now, let me know if you would like to make it more generic so that we could use it for both mandrel and graal. |
zakkak
force-pushed
the
2023-10-30-mandrel-disco
branch
3 times, most recently
from
b8c9c59
to
af83447
Compare
Since we can now define the distribution there is no longer the need to include the mandrel- prefix in Mandrel versions.
zakkak
force-pushed
the
2023-10-30-mandrel-disco
branch
from
af83447
to
01d1ada
Compare
fniephaus
approved these changes
Nov 3, 2023
| graalVMHome = await setUpMandrel(graalVMVersion, javaVersion) | ||
| } else { | ||
| throw new Error( | ||
| `Mandrel requires the 'version' option (see https://github.com/graalvm/setup-graalvm/tree/main#options).` |
There was a problem hiding this comment.
You probably still want to throw this error if graalVMVersion.length == 0, no? If I read this correctly, version: 'mandrel-22.2.0.0-Final' and version: '22.2.0.0-Final' will now do the same thing, but version is still required.
| javaVersion: string | ||
| ): Promise<string> { | ||
| const url = `${DISCO_API_BASE}?jdk_version=${javaVersion}&distribution=${c.DISTRIBUTION_MANDREL}&architecture=${c.JDK_ARCH}&operating_system=${c.JDK_PLATFORM}&latest=per_distro` | ||
| const _http = new httpClient.HttpClient('http-client-tests') |
There was a problem hiding this comment.
Not sure http-client-tests is supposed to be used in production code?
Thank you @fniephaus, I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mandrel-Closes #64