-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Plugins Use Metadata Repository by Default #557
Merged
dnestoro
merged 3 commits into
graalvm:master
from
dnestoro:dnestoro/UseMetadataRepositoryByDefault
Jan 23, 2024
Merged
Make Plugins Use Metadata Repository by Default #557
dnestoro
merged 3 commits into
graalvm:master
from
dnestoro:dnestoro/UseMetadataRepositoryByDefault
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jan 12, 2024
alvarosanchez
approved these changes
Jan 15, 2024
melix
approved these changes
Jan 22, 2024
olpaw
reviewed
Jan 22, 2024
...c/functionalTest/groovy/org/graalvm/buildtools/maven/MetadataRepositoryFunctionalTest.groovy
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Jan 22, 2024
olpaw
reviewed
Jan 22, 2024
olpaw
reviewed
Jan 22, 2024
olpaw
reviewed
Jan 22, 2024
native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/AbstractNativeMojo.java
Show resolved
Hide resolved
olpaw
reviewed
Jan 22, 2024
native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/AbstractNativeMojo.java
Outdated
Show resolved
Hide resolved
olpaw
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Small tweaks requested.
olpaw
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables usage of metadata repository by default in both Gradle and Maven plugins. See this issue