Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression with --exclude-config not specified anymore with 0.9.15 on Gradle #340

Closed
sdeleuze opened this issue Oct 17, 2022 · 0 comments
Closed

Regression with --exclude-config not specified anymore with 0.9.15 on Gradle #340

sdeleuze opened this issue Oct 17, 2022 · 0 comments
Labels
bug Something isn't working gradle-plugin Related to Gradle plugin
Milestone
0.9.16

Comments

@sdeleuze
Copy link
Collaborator

Based on my tests, NBT 0.9.15 Gradle plugin does not pass --exclude-config parameters to the native-image compiler anymore, breaking Netty 4 support.

It could have been cause by this code block removal but to be confirmed with @philwebb.

I am going to add a test to check this on Native Build Tools side.
@sdeleuze sdeleuze added bug Something isn't working gradle-plugin Related to Gradle plugin labels Oct 17, 2022
@sdeleuze sdeleuze added this to the 0.9.16 milestone Oct 17, 2022
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Oct 17, 2022
@sdeleuze
Modify tests to check --exclude-config works as expected
112c4fe 
Can now be checked by running OfficialMetadataRepoFunctionalTest.

See graalvmgh-340
@sdeleuze sdeleuze mentioned this issue Oct 17, 2022
Merged
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Oct 17, 2022
@sdeleuze
Modify tests to check --exclude-config works as expected
8360029 
Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle
and OfficialMetadataRepositoryFunctionalTest for Maven.

See graalvmgh-340
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Oct 17, 2022
@sdeleuze
Modify tests to check --exclude-config works as expected
ecb221b 
Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle
and OfficialMetadataRepositoryFunctionalTest for Maven.

See graalvmgh-340
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Oct 17, 2022
@sdeleuze
Modify tests to check --exclude-config works as expected
713010f 
Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle
and OfficialMetadataRepositoryFunctionalTest for Maven.

See graalvmgh-340
sdeleuze added a commit to sdeleuze/native-build-tools that referenced this issue Oct 17, 2022
@sdeleuze
Fix --exclude-config regression with Gradle
65777a7 
Closes graalvmgh-340
@sdeleuze sdeleuze mentioned this issue Oct 17, 2022
Closed
@melix melix closed this as completed in 05aa11c Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gradle-plugin Related to Gradle plugin
Projects
None yet
Milestone
0.9.16
Development

No branches or pull requests
1 participant
@sdeleuze