use checkstyle version 6.15 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrigger just because I saw you closed the other pull request: to update an existing pull request, simply push the new commits on to the branch used for the PR. You can also force-push to that branch if you want to discard incorrect commits. |
| @@ -5425,7 +5426,8 @@ def _load_projects(self): | |||
| javaCompliance = attrs.pop('javaCompliance', None) | |||
| if javaCompliance is None: | |||
| abort('javaCompliance property required for non-native project ' + name) | |||
| p = JavaProject(self, name, subDir, srcDirs, deps, javaCompliance, workingSets, d, theLicense=theLicense) | |||
| checkstyleName = self.getMxCompatibility().checkstyleLibraryName() | |||
There was a problem hiding this comment.
for consistency, checkstyleName should be checkstyleLibraryName
There was a problem hiding this comment.
Thanks, I made the naming consistent as you suggested.
There was a problem hiding this comment.
@smarr Thanks, I followed your advice and pushed the last fix to the PR branch.
dougxc
added a commit
that referenced
this pull request
Feb 3, 2016
added support for Checkstyle 6.15
dougxc
pushed a commit
that referenced
this pull request
Apr 14, 2016
…o master * commit '05493c3e9f289707c40226f61f4c2b2f09aa3a23': Compile Java projects using the default jdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes address issue #25. Suites that rely on older mx version will use Checkstyle 6.0, while newer ones will use 6.15.