Align artifact name with what GraalVM CE generates in its releases #467
+43
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
commented
Dec 19, 2024
| @@ -78,7 +78,8 @@ class Constants { | |||
| mv ${JAVA_HOME}/lib/static/darwin-arm64 ${JAVA_HOME}/lib/static/darwin-aarch64 | |||
| fi | |||
| ./jenkins/jobs/scripts/mandrel_linux_build.sh | |||
| # We align to what GraalVM CE calls its releases: | |||
| # We align to what GraalVM CE calls its releases | |||
| # this is no longer needed as of mandrel-packaging 24.2, but we keep it for backwards compatibility: | |||
There was a problem hiding this comment.
I plan to rebase 24.2 after merging this, since it's not tagged yet.
|
Looks like GHA needs some updates for this too: |
jerboaa
approved these changes
Dec 19, 2024
|
Github CI is happy now, @Karm do you anticipate any Jenkins CI failures due to this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #452