Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Use JVMCI for @Delete classes #22

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Sep 13, 2024

Partial backport of oracle/graal#8815

cherry picked from commit 30ae9d3c8dce269e1bcb9f1a090fddfff7d8eea4 trimmed to not include the API flag documentation change oracle/graal@30ae9d3#diff-b23354f77f5218c2b45167bd6d7887269ae1e8a91255e3db814e24706637327cL146-R146

Fixes oracle/graal#1725

Reproducer:

cd /tmp
git clone --branch 2024-09-13-delete-no-class-def-found https://github.com/zakkak/issue-reproducers reproducers
cd reproducers
mvn package
# run with Unreachable on the classpath
java -cp target/classes Main
# run with Unreachable not on the classpath
java \
  -jar target/reproducer-1.0-SNAPSHOT.jar
# generate native-image with Unreachable not on the classpath
native-image \
  --no-fallback \
  -H:+ReportExceptionStackTraces \
  -jar target/reproducer-1.0-SNAPSHOT.jar
# Run binary
./reproducer-1.0-SNAPSHOT
# generate native-image with Unreachable not on the classpath and pass --report-unsupported-elements-at-runtime
native-image \
  --no-fallback \
  --report-unsupported-elements-at-runtime \
  -H:+ReportExceptionStackTraces \
  -jar target/reproducer-1.0-SNAPSHOT.jar
# Build fails without the patch

(cherry picked from commit 30ae9d3c8dce269e1bcb9f1a090fddfff7d8eea4)
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 13, 2024
@zakkak zakkak requested a review from jerboaa September 13, 2024 10:18
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@zakkak zakkak merged commit a4bc8f4 into graalvm:master Sep 13, 2024
12 checks passed
@zakkak zakkak deleted the 2024-09-13-fix-1725 branch September 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native-image : @Delete expects all dependencies of target class to be available?
3 participants