fix: handle process.version set to undefined
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Sep 16, 2023
index.js
Outdated
Comment on lines
12
to
14
| if (typeof EdgeRuntime === "string") { | ||
| return "Edge Runtime"; | ||
| } |
There was a problem hiding this comment.
I don't feel too comfortable to start adding vendor-specific code. Could you for now leave that out and we discuss it in an issue? Maybe we can find another way
There was a problem hiding this comment.
For sure, removed
gr2m
approved these changes
Sep 18, 2023
gr2m
changed the title
process.version set to undefined
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Nov 4, 2023
Vercel's [Edge Runtime](https://edge-runtime.vercel.app/) is not Node.js, but will have a global `process` defined
gr2m
added a commit
that referenced
this pull request
Nov 4, 2023
Vercel's [Edge Runtime](https://edge-runtime.vercel.app/) is not Node.js, but will have a global `process` defined Co-authored-by: Jascha Ephraim <[email protected]>
This was referenced May 24, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #77
Related vercel/next.js#54739
The Edge Runtime is not Node.js, but will have a global
processdefined. Most properties ofprocesswill be present but undefined, so"version" in processwill be true. This will currently lead to a false identification as Node.js, and an error when callingprocess.version.substr(1). This PR instead checks thatprocess.version !== undefined.It also will check if
typeof EdgeRuntime === "string", which is how the Edge environment is checked in Vercel, and then return user agent "Edge Runtime" (which is not standard in any way, but possibly better than nothing). When a request is actually sent from a Vercel Edge function it has the user agent "Next.js Middleware", but I don't see anyway to detect that specifically.Let me know if you'd like me to remove this detection of the Edge Runtime and just fall back to
<environment undetectable>.