-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullsafe gql, gql_exec, gql_link #193
Conversation
…rseTypeSystemExtension conditional, as it looks like an old bug of some kind
Null safety migrations run thus far: Libraries
blocked by dart-lang/build#2920
Examples
|
Great work! I kind of forgot about the |
migrated
I'm thinking I should actually merge this into a |
I thought about the same thing because of the auto-release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost every single use of !
operator is a potential for a bug :(
Token _expectToken(TokenKind kind, [String errorMessage]) { | ||
final next = _next(); | ||
Token _expectToken(TokenKind kind, [String? errorMessage]) { | ||
final next = _next()!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a bug as well.
This is a first pass at a nullsafe
gql
, mostly done withdart migrate
and applied quick fixes. Idk what the status ofnnbd-gql
is – this was basically a "follow the instructions and see if tests pass" approach.