enhance: add functions for daemon tools to do mTLS #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
drpebcak,
thedadams,
njhale,
StrongMonkey and
iwilltry42
iwilltry42
reviewed
Dec 6, 2024
| print("error: GPTSCRIPT_CERT env var is empty") | ||
| exit(1) | ||
|
|
||
| cert_file = tempfile.NamedTemporaryFile(delete=False, suffix=".pem") |
There was a problem hiding this comment.
Do we need to protect those files with less permissions, e.g. via os.chmod(cert_file.name, stat.S_IRUSR | stat.S_IWUSR) (0600)?
There was a problem hiding this comment.
Good call. Just pushed this change.
iwilltry42
approved these changes
Dec 6, 2024
Signed-off-by: Grant Linville <[email protected]>
drpebcak
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to set up uvicorn for daemon tools. Uvicorn is the HTTP server that we use in our daemon tools in Python.
The test failures are nothing new and have appeared in other PRs. Probably just something that changed that we need to fix at some point.