enhance: upgrade edit page to use same tool catalog as chat page #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhopperlowe
requested review from
njhale,
StrongMonkey,
g-linville and
thedadams
thedadams
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Three additional pieces of feedback I have from running this:
- When I click on "Featured Tools", I get a nice pop up. I would expect to be able to dismiss this popup by click "outside" of it (or somewhere in the app that is not the popup). I am only able to dismiss it by selecting a tool or by hitting
Escon my keyboard. - When I click "Add Tool via URL", an input modal pops up. When I enter a URL and hit
Enter, the modal immediately disappears. It should stay visible until it is determined that the URL I entered actually works. - There is no validation done when adding a tool via URL. There was validation added in this PR: fix: try parsing tools added by URL to detect errors #397. Now, when I add a URL that doesn't exist (like
github.com/thedadams/dne), I get into a bad state when I reload the chat, as described in this issue: If I add a tool by URL and the url is bad/incorrect, I get in a bad state #296. The linked PR also fixed this problem.
thedadams
requested changes
Sep 4, 2024
thedadams
approved these changes
Sep 4, 2024
|
Looks good after error is fixed. |
@thedadams I found that I was able to fix the error by upgrading the Typescript version, so I opted for that instead :) |
ryanhopperlowe
force-pushed
the
enhance/edit-tool-catalog-improvement
branch
from
0361321 to
fd92257
Compare
drpebcak
reviewed
Sep 5, 2024
| { | ||
| name: 'Hubspot', | ||
| description: 'Allows the assistant to interact with Hubspot.', | ||
| url: 'github.com/gptscript-ai/tools/apis/hubspot/crm', |
There was a problem hiding this comment.
i have already fixed this, but just fyi the split has happened and this is no longer the correct url. its now github.com/gptscript-ai/tools/apis/hubspot/crm/write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.