-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #24
Update deps #24
Conversation
Seems like pip from pyenv gets in the way during the install of python3 in the destination path
Then it's not found when packaging. |
Do you know why modulesets/upstream-ref is not updated? |
Because I manually updated each moduleset file, then I saw upstream-ref and found fetch_modules.sh. It wasn't a waste of my time because gtk-osx.modules has --- a/modulesets-stable/gtk-osx.modules
+++ b/modulesets-stable/gtk-osx.modules
@@ -184,7 +184,7 @@
<meson id="harfbuzz" mesonargs="-Dcoretext=enabled -Dfreetype=enabled -Ddocs=disabled -Dbenchmark=disabled -Dintrospection=enabled">
<branch repo="github-tarball" version="4.1.0"
- module="harfbuzz/harfbuzz/releases/download/4.1.0/harfbuzz-4.1.0.tar.xz">
+ module="harfbuzz/harfbuzz/releases/download/4.1.0/harfbuzz-4.1.0.tar.xz"
hash="sha256:f7984ff4241d4d135f318a93aa902d910a170a8265b7eaf93b5d9a504eed40c8">
</branch>
<dependencies>
@@ -285,7 +285,7 @@
<meson id="graphene" mesonargs="-Dtests=false">
<branch repo="github-tarball" version="1.10.6"
- module="ebassi/graphene/releases/download/1.10.6/graphene-1.10.6.tar.xz"/>
+ module="ebassi/graphene/releases/download/1.10.6/graphene-1.10.6.tar.xz"
hash="sha256:80ae57723e4608e6875626a88aaa6f56dd25df75024bd16e9d77e718c3560b25"/>
<dependencies>
<dep package="glib"/>
@@ -338,7 +338,7 @@
<dep package="freetype"/>
</dependencies>
<after>
-<!-- Circular dependency if we depend on meta-gtk-osx-gtk3 -->
+ <!-- Circular dependency if we depend on meta-gtk-osx-gtk3 -->
<dep package="gtk+-3.0"/>
<dep package="gtk-4"/>
</after> |
@auouymous, re gpodder/gpodder#1348 (comment), I have the |
I tried
Even though This is so complicated. |
In the
Looking back in the logs, I stumbled upon this:
Yes, it found @auouymous is correct in #24 about disabling the |
So I ended up with the same |
Thank you for those links, I will try removing my brotli patch and see if github builds. It probably won't fix the pip issue but will remove the need for the patch. As for rolling back to the 3.10.21 bundle, changes were made for yt-dlp to work, and there is a change to fix a syncing issue. I don't know if the 3.10.21 bundle will build or not, but the last working commit used for 3.11.0 no longer builds. Even if the 3.10.21 bundle builds or can easily be made to build, it would require a gtk-osx update to make yt-dlp work. |
Seems that disabling brotli is still required. And latest gtk-osx fails to build libxml2, so no magic fix for the pip issue yet. |
@auouymous, this makes sense in general, some updated packages may be required. However why would For reference, my update branch: https://github.com/eunikolsky/gpodder-osx-bundle/tree/latest_moduleset. |
I didn't add support for yt-dlp in the bundle, I just remember the bundle being updated to make yt-dlp work on Mac. Also keep in mind that not all Mac users have the hidpi issue, and they might not agree with removing the yt-dlp support they depend on. As for https://github.com/eunikolsky/gpodder-osx-bundle/tree/latest_moduleset, I don't know why it would fail to download python with curl, but maybe it is because you used One of my recent commits in this PR pinned the repo in fetch_modules.py and added a comment to sync with the pin in bootstrap.py. Once this is working it might be a good idea to add a file sourced by both that holds the hash for gtk-osx and bundler, and mention that file in the readme. |
It finally built! @elelay Does this work? I had to remove the Tango theme, is that an issue? If this works, I will try putting pip back in, clean up the patches and get a gpodder build for testing. |
Hi, |
@auouymous the |
This is because re is now implemented as a folder with init.py, etc. vs re.py in previous version. Here are build logs grepped using
|
I added the missing modules, can you test again when it finishes building? |
It works but pip3 is missing |
@elelay Do you know how to make it install pipenv 2022.11.4 or newer. I don't know if it would fix the failure, but the runtime instrospection warnings are caused by an older version that doesn't fully support python 3.11. |
https://gitlab.gnome.org/GNOME/gtk-osx/-/blob/master/gtk-osx-setup.sh#L109 chooses the version. |
nice try :-) |
Yeah, so when python3 install bootstraps pip by calling |
Can you create
then call |
|
maybe rollback 59ebd8d? |
My mistake: the --root .... argument should not be there. See
in the logs. Please replace in runit.sh with:
|
That worked! |
@elelay Does this build work any better? |
I need to rebuild to access artifacts. If this build doesn't work, do you mind pushing to a branch in gpodder-osx-bundle ? Maybe then I access your artifacts? |
I added you to my fork, hopefully that gives you access to future artifacts there. |
YES! |
I was able to create a package from gpodder, I just had to |
I'll clean up the commits and try to get a gpodder build out today for others to test! 🎆 |
The pip sed is no longer needed. Add comment to explain the other sed.
@elelay Do you know how to fix this issue on line 10 in bundle.sh?