Feature: Expand envrionment variables on secrets #824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Better developer experience
What
Nx expands environment variables by default when placed in the
project.json
. For example,will successfuly pass the argument to the image with the expanded value of the environment variable
NPM_TOKEN
. Howeverwill not. This is because the code right now uses that literal string.
This PR expands the environment variables to provide the implicit developer experience. It will likely takcle issues like #595 where people seem confused regarding this feature. Today we provide examples on how to do this, but only works on CI where value is passed already expanded with the
INPUT_
env var like in #650How
Adds a small function to expand the vars and makes use of it both in
dockerx
andpodman