Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix umd build #651

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Fix umd build #651

merged 2 commits into from
Mar 6, 2018

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Mar 5, 2018

Fixed version
Ref #650 #637 #649

@gpbl
Copy link
Owner

gpbl commented Mar 6, 2018

Could you run yarn lint --fix please? 🙏 Thanks!

@gpbl gpbl added this to the v7.1.2 milestone Mar 6, 2018
@gpbl gpbl added the v:patch label Mar 6, 2018
@TrySound
Copy link
Contributor Author

TrySound commented Mar 6, 2018

Done

@codecov
Copy link

codecov bot commented Mar 6, 2018

Codecov Report

Merging #651 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #651   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         622    619    -3     
  Branches      136    136           
=====================================
- Hits          622    619    -3
Impacted Files Coverage Δ
src/DayPicker.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7920572...591a284. Read the comment docs.

@gpbl gpbl merged commit 5b06eb1 into gpbl:master Mar 6, 2018
@gpbl
Copy link
Owner

gpbl commented Mar 6, 2018

Thanks man

@TrySound TrySound deleted the fix-umd-again branch March 6, 2018 14:19
@gpbl gpbl mentioned this pull request Mar 8, 2018
Merged
@gpbl
Copy link
Owner

gpbl commented Mar 8, 2018

Sorry, this still doesn't work. Getting the same error #649

We need to add a test for making sure DateUtils is being exported correctly.

Anyway, which UMD error are you referring to? How can I replicate it?

@TrySound
Copy link
Contributor Author

TrySound commented Mar 8, 2018

Weird, I checked this locally. Everything worked fine.

@gpbl gpbl removed this from the v7.1.2 milestone Mar 8, 2018
@gpbl
Copy link
Owner

gpbl commented Mar 8, 2018

Maybe I pulled something wrong? Let me try again.

@TrySound
Copy link
Contributor Author

TrySound commented Mar 8, 2018

Probably. Here's the problem. Just open console
https://codepen.io/TrySound/pen/NYKQMY

@TrySound
Copy link
Contributor Author

TrySound commented Mar 8, 2018

@gpbl Did you tried to pull again?

gpbl added a commit that referenced this pull request Mar 14, 2018
@gpbl
Revert #651
a0f6679
gpbl added a commit that referenced this pull request Mar 14, 2018
@gpbl
Merge pull request #665 from gpbl/fix-wrong-release
d2d112d 
Revert #651
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
@gpbl
Merge pull request gpbl#651 from TrySound/fix-umd-again
dafdef7 
Fix umd build
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
@gpbl
Revert gpbl#651
f68d49e
kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
@gpbl
Merge pull request gpbl#665 from gpbl/fix-wrong-release
00693a6 
Revert gpbl#651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrySound @gpbl