Typescript type definitions: missing third parameter in renderWeek #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #575 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 609 609
Branches 129 129
=====================================
Hits 609 609Continue to review full report at Codecov.
|
|
Great find! thanks! |
gpbl
changed the title
|
Published as v7.0.3 |
|
thanks! |
kimamula
pushed a commit
to kimamula/react-day-picker
that referenced
this pull request
Aug 17, 2022
Typescript type definiton doesn't provide the third parameter in renderWeek. Could you please add this. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Type definition doesn't provide the third parameter added in #546. Please add this parameter. Thanks