This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Refactoring things #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| margin-right: ($card-padding * -1); | ||
| margin-bottom: $card-padding; | ||
| //border-bottom: solid 1px $border-color; | ||
| margin-top: ($card-padding * -1) ($card-padding * -1) ($card-padding * -1) $card-padding; |
There was a problem hiding this comment.
@una did you mean here margin, or does margin-top accept 4 values? I'd use:
margin: ($card-padding * -1) ($card-padding * -1) ($card-padding * -1) $card-padding;There was a problem hiding this comment.
good catch. definitely meant margin
|
Thanks. For the accessibility we should follow also this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit more code cleanup. Still wondering where some of the numbers are coming from though -- figuring that out could help make some nice DRY loops :)