-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix js error #819
base: master
Are you sure you want to change the base?
Fix js error #819
Conversation
…edText of startLine has not text attribute
Also solves: #817 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear this is just avoiding the error but not fixing the underlying problem
I have a PR for only part of these changes. These should be linked. |
Does anyone figured why this happening? In my case, doing migration js>ts(x) and just started to seeing this error. Assuming some upstream is screwing the sourcemaps (webpack + babel (react) + typescript + karma)? |
@FezVrasta yes this is not a fix, it's just a "silent" fail. I think there should be an error thrown instead that just looks better than "TypeError", which would tell you that the coverage report cannot be mapped to the source file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix works perfectly.
Can this get merged?
+1 👍 |
Fix js error when there is no structuredText of startLine or structuredText of startLine has not text attribute.
Also fixes this issueon karma-coverage: karma-runner/karma-coverage#167