feat(tag): introduce size prop to Tag component
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekv24
reviewed
Jun 19, 2024
| ...props | ||
| }: TagProps) => { | ||
| const [visible, setVisible] = useState(true); | ||
| if (!visible) return null; | ||
| return ( | ||
| <TagWrapper> | ||
| <StyledTag {...props} type={type} color={color} closable={closable} icon={icon ? true : false}> | ||
| <StyledTag {...props} type={type} color={color} closable={closable} icon={icon ? true : false} size={size}> |
There was a problem hiding this comment.
If we are only changing the font-size using this prop then let's rename it to fontSize to avoid confusion?
There was a problem hiding this comment.
this new prop is to let user customize the Tag sizing using small | medium | large value without having to care about font sizing or other styling. And apparently, this only needs to change the font size because the wrapper box size will also adapt based on the font size.
on the other hand, if user need to customize this component's font size they can use props.style
idilhaq
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.