forked from raystack/apsara
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Listing): enrich props with types and use generic types #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushi0014
changed the title
WIP: refactor listing component to make it more generic and compatible to use
[DFEXP: 125]: refactor listing component to make it more generic and compatible to use
Sep 15, 2023
abhishekv24
reviewed
Sep 15, 2023
StewartJingga
requested changes
Sep 15, 2023
StewartJingga
requested changes
Sep 15, 2023
ayushi0014
changed the title
[DFEXP: 125]: refactor listing component to make it more generic and compatible to use
refactor(Listing): enrich props with types and use generic types
Sep 15, 2023
…ts updated when filter is not present
ayushi0014
force-pushed
the
fix-listing-component
branch
4 times, most recently
from
September 21, 2023 06:57
fb1a0f3
to
ba99c6f
Compare
ayushi0014
force-pushed
the
fix-listing-component
branch
from
September 21, 2023 09:08
ba99c6f
to
b4b3fa3
Compare
StewartJingga
requested changes
Sep 21, 2023
StewartJingga
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.