-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github cache #53
Merged
Merged
Use github cache #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
added a commit
that referenced
this pull request
Jun 25, 2023
* Cache the zig compiler locally * logging * npm update * verboser * os.arch * debug * log signal * address actions/toolkit#687 * correct path * add a cache: false option * share size * zigpath * path.join skull
goto-bus-stop
added a commit
that referenced
this pull request
Jun 25, 2023
* deps: use esbuild * deps: update tool-cache * Fix tool-cache usage (#45) * cache log * log * log * use resolved ver for cache * build * log cache * log * use version as key * deps * loggggggg * method name * improve log * ci: tweak versions * include version for commit deps * trailing * mistake * Use github cache (#53) * Cache the zig compiler locally * logging * npm update * verboser * os.arch * debug * log signal * address actions/toolkit#687 * correct path * add a cache: false option * share size * zigpath * path.join skull * target node12 * changelog: add 1.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is admittedly a little janky but it is the easiest way to add caching without changing the existing code. Should make it easy to backport to v1 of the action which is widely in use.
This really should address #44 :)
Users can disable it with
cache: false
if it causes problems for some reason, but it's enabled by default to hopefully reduce the downloads from ziglang.org quite a bit. It's also significantly faster with caching since Github's caches are ultra local...