change: removal of disabled flag from messages Refresh button #637
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 44 44
Lines 1593 1593
=======================================
Hits 1383 1383
Misses 125 125
Partials 85 85 ☔ View full report in Codecov by Sentry. |
| @@ -70,7 +70,6 @@ class Messages extends Component<IProps & Stores<'messagesStore' | 'appStore'>, | |||
| <Button | |||
| id="refresh-all" | |||
| variant="contained" | |||
| disabled={!hasMessages} | |||
There was a problem hiding this comment.
If the webapp is cache-reopened, then it's likely that the websocket connection isn't reconnected. So you will be able to refresh the messages, but this won't reconnect the websocket.
There was a problem hiding this comment.
Could we somehow get the refresh button to check connection status and call upon WebSocketStore.listen if needed? I'm not all familiar with how react works.
There was a problem hiding this comment.
Possible yes, but I'd rather solve this automatically on page load but I currently don't know a way to reproduce this cached reopen where the site state is kept.
There was a problem hiding this comment.
Assuming your browser reopens previously opened tabs, open gotify in a tab and close the browser. Reopen the browser and thats it. Or open gotify, leave the browser open and sleep the computer. (I'm using Firefox)
There was a problem hiding this comment.
I'm doing this, but my firefox correctly reestablishes the websocket connection and has messages that were sent while the browser was closed.
In reference to #636