Mitigate go test bug with missing subtest pass events #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all missing events were reported. This commit omits events for any missed subtests, so that subtests that passed do not show as failed. The upstream bug was fixed in go1.16, so this mitigation probably does not need to stick around for long. Co-Authored-By: Aaron Lehmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the changes in #188
Fixes #141
Previously all missing events were reported. This commit omits events for any missing subtests pass events, so that subtests that passed do not show as failed.
The upstream bug was fixed in go1.16, so this mitigation probably does not need to stick around for long.
@aaronlehmann I added you as a co-author to this commit since this was heavily inspired by your change. I hope that is ok.