Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop go1.16 from test-matrix, replace deprecated io/ioutil, and update golangci-lint to v1.49.0 #245

Merged
merged 5 commits into from
Oct 6, 2022
Merged

drop go1.16 from test-matrix, replace deprecated io/ioutil, and update golangci-lint to v1.49.0 #245

merged 5 commits into from
Oct 6, 2022

Commits on Oct 4, 2022

  1. remove go1.16 from test matrix 

    Both go1.16 and go1.17 reached EOL; keeping go1.17 for now, as there may
still be projects that are slightly behind.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    b9a752f View commit details
    Browse the repository at this point in the history

  2. fix formatting of nolint tags 

    Also replacing some of them, as there's more linters that check for this
now (revive being one of them), so "fixing" them prevents having to add
more linters to the list.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f0f4764 View commit details
    Browse the repository at this point in the history

  3. replace uses of deprecated io/ioutil 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    b881b33 View commit details
    Browse the repository at this point in the history

  4. Add package GoDoc for some internal packages (revive) 

        internal/maint/maint.go:1:1: package-comments: should have a package comment (revive)
    package maint // import "gotest.tools/v3/internal/maint"
    internal/format/diff.go:1:1: package-comments: should have a package comment (revive)
    package format
    icmd/internal/stub/main.go:1:1: package-comments: should have a package comment (revive)
    package main
    internal/source/defers.go:1:1: package-comments: should have a package comment (revive)
    package source
    internal/assert/assert.go:1:1: package-comments: should have a package comment (revive)
    package assert

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    77e24c3 View commit details
    Browse the repository at this point in the history

  5. update golangci-lint to v1.49.0 

    Also replaced deprecated linters:

    WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
    WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.
    WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.
    WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5b51cec View commit details
    Browse the repository at this point in the history