Add flag to disable login on multiple hosts #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
|
cc: @carmark - can you please help with this review. |
|
@kmova sure, @shubham14bajpai thanks for your patch |
|
@shubham14bajpai Could you please also add a flag for the |
Signed-off-by: shubham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham [email protected]
This PR adds a new flag to enable blocking of login from multiple hosts. This feature is required for implement a RWO volume in kubernetes environment where even though we mention RWO in the persistent volume still in some scenarios multiple pods on different hosts can mount the same volume, ref : openebs/openebs#3404 .
This can be prevented from the CSI drivers, but we can not guarantee that pods will not mount the same volume in some edge cases. It is good to reject a new login when a connection already exists to ensure there is no data corruption.
By default, this feature is disabled and can be enabled when creating a new Target object using
EnableBlockMultipleHostLogin