feat!: quantitativeFields
is removed entirely from csv
and json
data specs
#613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
quantitativeFields
entirely fromcsv
andjson
data specs. This property was unnecessary since we generatescale
s per visual channel, and the value type (i.e., quantitative vs. nominal) is determined at the time we generate scales, not at the time we parse data. More detailed discussions can be found at #579.Breaking Updates
If you were using
quantitativeFields
in the data properties, you just need to remove them from your spec:data: { url: 'https://raw.githubusercontent.com/sehilyi/gemini-datasets/master/data/cytogenetic_band.csv', type: 'csv', chromosomeField: 'Chr.', genomicFields: ['ISCN_start', 'ISCN_stop', 'Basepair_start', 'Basepair_stop'], - quantitativeFields: ['Band', 'Density'] },
Fix #579