Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: quantitativeFields is removed entirely from csv and json data specs #613

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

sehilyi
Copy link
Member

@sehilyi sehilyi commented Dec 17, 2021

This removes quantitativeFields entirely from csv and json data specs. This property was unnecessary since we generate scales per visual channel, and the value type (i.e., quantitative vs. nominal) is determined at the time we generate scales, not at the time we parse data. More detailed discussions can be found at #579.

Breaking Updates

If you were using quantitativeFields in the data properties, you just need to remove them from your spec:

data: {
    url: 'https://raw.githubusercontent.com/sehilyi/gemini-datasets/master/data/cytogenetic_band.csv',
    type: 'csv',
    chromosomeField: 'Chr.',
    genomicFields: ['ISCN_start', 'ISCN_stop', 'Basepair_start', 'Basepair_stop'],
-   quantitativeFields: ['Band', 'Density']
},

Fix #579

@sehilyi sehilyi changed the title feat!: quantitativeFields is removed entirely from csv and json data specs feat!: quantitativeFields is removed entirely from csv and json data specs Dec 17, 2021
@sehilyi sehilyi requested a review from manzt December 17, 2021 18:19
Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM.

I know we chatted about this previously, but can you remind me why genome fields are necessary again? Is it something about calculating the "absolute" genomic position? found in previous discussion!

@sehilyi
Copy link
Member Author

sehilyi commented Dec 17, 2021

I think I need to add a proper description about the genomics fields to our docs.

@sehilyi sehilyi merged commit 01661c1 into master Dec 20, 2021
@sehilyi sehilyi deleted the sehilyi/no-quantitative branch December 20, 2021 17:17
@sehilyi sehilyi mentioned this pull request May 11, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More concise (text-based) columnar data definitions
2 participants