Skip to content

Commit

Permalink
Remove artificail failures.
Browse files Browse the repository at this point in the history
  • Loading branch information
gmagnu committed Nov 12, 2024
1 parent 896aa7c commit c3ca5f3
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 19 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,20 +124,21 @@ jobs:
- uses: actions/checkout@v4
- name: Download artifacts
uses: actions/download-artifact@v4
- name: Publish Test Report
uses: mikepenz/action-junit-report@v4
if: always() # always run even if the previous step fails
with:
report_paths: '**/TEST-*.xml'
- name: Test Report
uses: dorny/test-reporter@v1
if: always() # run this step even if previous step failed
#Disalbe for now because of the 64k limit, use mikepenz instad for the summary.
if: false #always() # run this step even if previous step failed
with:
name: Junit Tests - all # Name of the check run which will be created
path: '**/TEST-*.xml' # Path to test results
reporter: java-junit # Format
list-tests: failed
list-suites: failed
- name: Publish Test Report
uses: mikepenz/action-junit-report@v4
if: always() # always run even if the previous step fails
with:
report_paths: '**/TEST-*.xml'

publishSnapshot:
if: ${{ github.ref == 'refs/heads/githubtest' }}
Expand Down
26 changes: 13 additions & 13 deletions drivers/src/testFixtures/java/org/gorpipe/utils/DriverUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,19 @@ public class DriverUtils {

public static Properties getDriverProperties() {
Properties prop = new Properties();
// if (Files.exists(Paths.get(SECRETS_FILE_NAME))) {
// log.debug("Loading env: " + SECRETS_FILE_NAME);
// try (InputStream inputStream = new FileInputStream(SECRETS_FILE_NAME)) {
// prop.load(inputStream);
// } catch (IOException e) {
// // Do nothing
// log.warn("Error reading secrets file", e);
// }
// } else {
// log.warn("No secrets file found {}", SECRETS_FILE_NAME);
// }
//
// prop.putAll(System.getenv());
if (Files.exists(Paths.get(SECRETS_FILE_NAME))) {
log.debug("Loading env: " + SECRETS_FILE_NAME);
try (InputStream inputStream = new FileInputStream(SECRETS_FILE_NAME)) {
prop.load(inputStream);
} catch (IOException e) {
// Do nothing
log.warn("Error reading secrets file", e);
}
} else {
log.warn("No secrets file found {}", SECRETS_FILE_NAME);
}

prop.putAll(System.getenv());

return prop;
}
Expand Down

0 comments on commit c3ca5f3

Please sign in to comment.