Swtich to list from walk as it seems more stble for S3.

gorpipe · Dec 25, 2024 · 386d078 · 386d078
1 parent 7c2ba9b
commit 386d078
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/drivers/src/main/java/org/gorpipe/s3/driver/S3SourceProvider.java b/drivers/src/main/java/org/gorpipe/s3/driver/S3SourceProvider.java
@@ -157,7 +157,8 @@ private S3Client createClient(Credentials cred) {
     AwsCredentialsProvider getCredentialsProvider(Credentials cred) {
         if (cred == null || cred.isNull()) {
             log.info("CredentialsProvider: DefaultCredentialsProvider for null creds");
-            return DefaultCredentialsProvider.create();
+            throw new IllegalArgumentException("Credentials are required for S3 access");
+            //return DefaultCredentialsProvider.create();
         } else {
             var awsKey = cred.getOrDefault(Credentials.Attr.KEY, "");
             var awsSecret = cred.getOrDefault(Credentials.Attr.SECRET, "");
@@ -181,7 +182,8 @@ AwsCredentialsProvider getCredentialsProvider(Credentials cred) {
                 }
             } else {
                 log.info(String.format("CredentialsProvider: DefaultCredentialsProvider for %s:%s", cred.getService(), cred.getLookupKey()));
-                return DefaultCredentialsProvider.create();
+                throw new IllegalArgumentException(String.format("CredentialsProvider: DefaultCredentialsProvider for %s:%s", cred.getService(), cred.getLookupKey()));
+                //return DefaultCredentialsProvider.create();
             }
         }
     }