More feature flags.

gorpipe · Dec 28, 2024 · 2d8d644 · 2d8d644
1 parent a7c50c3
commit 2d8d644
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/drivers/src/main/java/org/gorpipe/s3/driver/S3SourceProvider.java b/drivers/src/main/java/org/gorpipe/s3/driver/S3SourceProvider.java
@@ -59,6 +59,7 @@
 public class S3SourceProvider extends StreamSourceProvider {
 
     private static final boolean USE_CRT_CLIENT = Boolean.parseBoolean(System.getProperty("gor.s3.client.crt", "false"));
+    private static final boolean USE_NETTY_CLIENT = Boolean.parseBoolean(System.getProperty("gor.s3.client.netty", "true"));
 
     private final Cache<String, S3Client> clientCache = CacheBuilder.newBuilder()
             .expireAfterAccess(1, TimeUnit.HOURS)
@@ -222,14 +223,17 @@ private S3Client createApacheClient(Credentials cred) {
     }
 
     protected S3AsyncClient getAsyncClient(String securityContext, String bucket) throws IOException {
-        BundledCredentials creds = BundledCredentials.fromSecurityContext(securityContext);
-        return asyncClientCredCache.getClient(creds, bucket);
-    }
-
-    private S3AsyncClient createAsyncClient(Credentials cred) {
         if (USE_CRT_CLIENT) {
             return null; //createCrtAsyncClient(cred);
         }
+        if (USE_NETTY_CLIENT) {
+            BundledCredentials creds = BundledCredentials.fromSecurityContext(securityContext);
+            return asyncClientCredCache.getClient(creds, bucket);
+        }
+        return null;
+    }
+
+    private S3AsyncClient createAsyncClient(Credentials cred) {
         return createNettyClient(cred);
     }