-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets over HTTP/2 #417
Comments
I hadn’t seen that link! But still very early in the process, and
WebSockets + HTTP/2 have been in limbo for a while. My confidence that this
goes ahead in the next 6 months is low.
I can say that no work is *planned*, although Gary may have thought about
it.
Saying all of that: we are open to design documents laying out what needs
to be added and changed to support WS over HTTP/2.
…On Sun, Aug 26, 2018 at 10:07 AM Kane York ***@***.***> wrote:
Is gorilla/websocket going to be doing an experimental implementation of
the Websockets+h2 draft, or waiting for it to go RFC?
https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-07
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#417>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIcGGAx_3gGKGhO31_v_leTWHoFHtwks5uUtW5gaJpZM4WM3CD>
.
|
I prefer to let the browsers lead on protocol features. Do you know where browsers are with the proposal? If it looks like one or more browsers will implement the RFC, then the implementation should be sketched out in case changes are needed to the net/http or golang.org/x/net/http2 packages. I don't know of any plans to do this work. |
Yes, I was alerted to this via the blink-dev Intent To Ship where they say Mozilla also intends to implement it. Intent to Implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/TQN4jWHydTk/discussion This probably isn't shipping before the end of the year, no. |
This would require support from net/http for the CONNECT method protocol extension. |
Some discussion also at coder/websocket#4 |
It's still TCP at the bottom, so there's no real point. |
It's useful for the same reason it's useful for normal HTTP requests, built in pipelining. Means you can use a single TCP connection with multiple websockets instead of having to implement your own pipelining protocol over websockets. Certainly not a game changer but a nice addition nonetheless. |
It seems to reduce performance. Does the browser client support this?
|
Depends on the use case.
Yes, browsers do support WebSockets over HTTP/2. |
Any updates? |
It seems this will be possible now , since golang http2 supports to pass the extended connect https://go-review.googlesource.com/c/net/+/610977 |
POC using the existing websocket library in golang https://go-review.googlesource.com/c/net/+/632755 |
Is gorilla/websocket going to be doing an experimental implementation of the Websockets+h2 draft, or waiting for it to go RFC?
https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-07
The text was updated successfully, but these errors were encountered: