Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on gorilla/context for go1.7+ #42

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

mna
Copy link
Contributor

@mna mna commented Jul 20, 2016

Hello,

This finishes what was started a few commits ago by moving the use of gorilla/context behind a build tag, so that for Go1.7+ that package isn't used anymore. It adds the missing contextClear func, and uses the contextSave call to set the error in the context while making sure to change the *http.Request to the one returned by contextSave.

Thanks,
Martin

@elithrar elithrar self-assigned this Jul 21, 2016
@elithrar
Copy link
Contributor

Good catch—thanks for this @PuerkitoBio!

@elithrar elithrar merged commit a9c30ae into gorilla:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants