Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal does not render when unmounting PortalHost and remounting again #18

Closed
mrousavy opened this issue Aug 23, 2021 · 4 comments
Closed

Portal does not render when unmounting PortalHost and remounting again #18

mrousavy opened this issue Aug 23, 2021 · 4 comments
Assignees
@gorhom

Comments

@mrousavy
Copy link

Awesome library @gorhom!

In my use-case, I conditionally render a <PortalHost>. This works on the first time, but after unmounting it and mounting it again, the Portal inside does not render anymore.

I'd love to provide a reproduceable example, but unfortunately the codebase is very nested and WIP right now, if you have trouble reproducing this I could try patching something together..

Thanks!
@gorhom gorhom self-assigned this Aug 23, 2021
@gorhom
Copy link
Owner

gorhom commented Aug 23, 2021

Hey @mrousavy , i will look into it 👍

gorhom added a commit that referenced this issue Aug 23, 2021
@gorhom
fix: allow PortalHost to mount/unmount safely #18
05042e5
@gorhom
Copy link
Owner

gorhom commented Aug 23, 2021

should be fixed with v1.0.8

@gorhom gorhom closed this as completed Aug 23, 2021
@janvandertaelen
Copy link

I also have the same issue on version v1.0.12. When the host is conditionally hidden it doesn't reappear

@roviks
Copy link

roviks commented Jul 25, 2022

@gorhom still not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorhom gorhom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhom @mrousavy @roviks @janvandertaelen