Skip to content

Commit

Permalink
fix: updated containerOffset top value to default to 0 (#1420)(by @be…
Browse files Browse the repository at this point in the history
…qramo)

* fix: keyboard on focus

* fix: updated containerOffset top value to default to 0

---------

Co-authored-by: Mo Gorhom <[email protected]>
  • Loading branch information
beqramo and gorhom authored Jul 15, 2023
1 parent 1ecad69 commit 218e006
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/components/bottomSheetContainer/BottomSheetContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ function BottomSheetContainerComponent({
containerRef.current?.measure(
(_x, _y, _width, _height, _pageX, pageY) => {
containerOffset.value = {
top: pageY,
top: pageY ?? 0,
left: 0,
right: 0,
bottom: Math.max(
0,
WINDOW_HEIGHT - (pageY + height + (StatusBar.currentHeight ?? 0))
WINDOW_HEIGHT - ((pageY ?? 0) + height + (StatusBar.currentHeight ?? 0))
),
};
}
Expand Down

2 comments on commit 218e006

@CarlMenke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea when the release for 4.4.8 that will include this fix will be live?

@CarlMenke
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I found that if you remove the animationConfigs prop from the BottomSheetModal then it will fix the issue.

Please sign in to comment.