Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance for the Serbo-Croatian Filters section #3924

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Sep 4, 2024

  • Added 2 CDNs, one of which lead to GitLab as is the case for Nordic Filters (Last night's temporary takedown for a few hours of the AdGuardFilters GitHub repo, made me extra aware of the need for non-GitHub backup hostings).
  • Firefox's download pages list Bosnian as a distinct option, so I added their download page's ISO code for Bosnian to the "lang" values.

While I remember it's been wished for before to make threads for it in uBlock-issues instead of PRs, to make more people able to comment on suggested changes of mine, this one should on paper be simple enough to not need such a thread… I think.

@gorhill
Copy link
Owner

gorhill commented Sep 4, 2024

If you want fallback URLs, best to add them to contentURL, i.e. convert to an array and append the URLs to the existing contentURL one. Using cdnURLs in your case will cause the relatively stale URLs you specified to always be used in lieu of the more reliable raw.githubusercontent.com one. The fact that your list does not use a ! Last-Modified: field means uBO's auto-update code will be unable to tell whether the list downloaded from one of the new URLs is more recent than the one currently cached. For cases of fallback URLs, they need to be appended to contentURL.

@DandelionSprout
Copy link
Contributor Author

DandelionSprout commented Sep 4, 2024

I guess I'll need to do some changes to Nordic Filters too in that case, which has many of the same shortcomings in both assets.json and plausibly within the list itself.

I sure I hope I understood the request correctly, or things would get slightly awkward for me.
DandelionSprout added a commit to DandelionSprout/adfilt that referenced this pull request Sep 5, 2024
@gorhill gorhill merged commit 8631b95 into gorhill:master Sep 5, 2024
gorhill added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants