-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline script tag filtering - Concrete examples of usefulness #795
Comments
Interesting challenge, will see what can be done -- if something can be done with the new filter. Can you give me a specific URL on that site for which the issue occur for sure, I don't feel like hunting for a test case -- I just need one URL. |
@gorhill Just click on any video on pornhub.com to trigger a popunder. In fact, this mechanism is used for all popunder in sites of the the whole Pornhub NETWORK (pornhub.com, redtube.com, etc)! |
Does this work?
|
@gorhill Amazing, that worked in uBlock Origin 1.2.0 with over 400k daily users on AMO at this writing! Congratulations to be the first developer to ever have blocked inline scripting AFAIK! Can you please add |
Ok, added Even with this new filter, just a reminder this it is still a cat and mouse game between sites/blockers -- the new inline script tag filter is just one more tool on the blocker side. |
Also, can you please write about this in
|
@gorhill Thank you. Where did you add |
Not sure I want to "advertise" this on EasyList forum, I wouldn't be surprised if the site's owners have people monitoring the latest solutions in there against their pop-under "feature". |
It's in https://github.com/gorhill/uBlock/blob/master/assets/ublock/filters.txt. |
@gorhill Thank you. Is it ok if I give you code to block popunders for the rest of the Pornhub NETWORK in https://github.com/gorhill/uBlock/blob/master/assets/ublock/filters.txt ? |
If you can confirm it works for all of them -- that will save me having to check. |
@gorhill MindGeek domains using
I recommend that you add them to https://github.com/gorhill/uBlock/blob/master/assets/ublock/badware.txt per https://en.wikipedia.org/wiki/MindGeek#Malvertising. What do you think about it? |
Added suggested filter. FYI, I had to edit your suggested filter:
|
@gorhill Peter Lowe ignored adding these to his List: [Aftermath: Wrong filter list] |
I see most of them in Peter Lowe's list. To be clear, I do not intend to become a filter list maintainer -- whatever I put in uBlock's filter lists is completely at my own discretion, I do not intend to take requests to add stuff in these lists, these requests should be directed to known filter list maintainers -- except for filters based on syntax extension (like the new inlien script tag filter). |
@gorhill Out of curiosity, why didn't you move If you add the domains to https://github.com/gorhill/uBlock/wiki/Badware-risks then write the titles like this, "Pornhub NETWORK: Blank", to be able to keep track of what belongs to the Pornhub NETWORK and not. See https://github.com/lejenome/html5-video-everywhere/issues/41 for example. |
Because this filter is to prevent spurious popunders, not warn of risk of badware ahead. |
Short question: Because this could be a bit misleading, as I just read these Examples.
I guess this won't work then for users with current Firefox and uBlock0 versions. I also noticed that these filters don't work in Chrome/Chromium, but this is correct, according to the same page (caveats). |
Good points, I fixed the doc. |
@gorhill I guess it would be good to state in https://github.com/gorhill/uBlock/wiki/Badware-risks that "*.exe" files are the most common practice to spread malware files. What do you think? |
That is true, I guess. But, in my humble opinion, that is fundamental common sense of using the Internet. The Badware warning is to remind users to be cautious, it's not an exhaustive guide of using the Web safely. uBlock0 is not Internet Basics 101, so this is out of scope for this project. |
@gorhill pornhub.com popunders have been resurrected, despite that pornhub pages still use FastPopSessionRequestNumber. Can you fix this? Mabybe by modifying |
I can't reproduce, works from here. Anything out of the ordinary with your environment? |
@gorhill Yes, I upgraded from IceCat 31 to IceCat 38. Nothing more than that. |
@gorhill However, the popunders are catched by strict blocking: ** Because of the following filter ||ebocornac.com^ Still annoying with the opened tab though. |
What is the result of this test for IceCat 38? |
|
@gorhill I downloaded and installed Trisquel 7 from trisquel.info and installed icecat with: apt-get update && apt-get install icecat. This is the absolutely safest way to make sure that one get the latest version of icecat as the maintainer of IceCat also is the lead developer of Trisquel. Trisquel GNU/Linux can be used live from USB. |
@gorhill IceCat 38.3.0 is based on Firefox ESR. You can download and try the latest FF ESR here: https://ftp.mozilla.org/pub/firefox/releases/latest-esr/ |
Ok I installed and investigated. The reason is simply that FF 38 API does not support process message managers, which is required in the current implementation of inline script tag filtering. |
@gorhill You introduced the In assets/ublock/filters.txt, should Also, https://github.com/gorhill/uBlock/wiki/popunder is empty. I need it as a reference, should I look elsewhere? |
I can't see any popunders anymore on these sites, I may have to remove the corresponding |
@gorhill The questions is, do the popunder filter type block |
@gorhill Can you please add |
Pornhub.com have Global Alexa Rank 65 at this writing.
Can you please add how to block the popunder for pornhub.com in https://github.com/gorhill/uBlock/wiki/Inline-script-tag-filtering#concrete-examples-of-usefulness ?
What do you think about adding https://adblockplus.org/forum/viewtopic.php?t=27067 as reference to the text: "http://dayt.se/forum/activity.php: dayt.se##script:contains(adBlockDetected) (see "Blocking FuckAdblock")" in https://github.com/gorhill/uBlock/wiki/Inline-script-tag-filtering#concrete-examples-of-usefulness ?
The text was updated successfully, but these errors were encountered: