-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When allowing "All" the requests for a site, there are still requests that get blocked #510
Comments
@gwarser So how would you explain that when marking the per site "3rd-party scripts" with a no-op (when the global "3rd-party scripts" is marked red), combined with the "All" cell marked green, I still get some requests going in? per site rules should always take precedence. So, to recap, the "All" row is the least important in the Dynamic Filtering rules, I get that, but it should not be inferior to the static rules... right? |
By design. The
What does "requests going in" mean? I noop'ed the local In the following picture: Bottom part is your step 1-3:
Top part is when locally noop'ing 3rd-party scripts:
|
@gorhill You are right.. the 3rd-party scripts get allowed/disabled as it should per no-op'ing, my bad.. |
It is, unless a narrower rule says to disregard dynamic filtering, which is what |
Yes, I see how it all fits now. |
Steps to reproduce:
An important note: If then (after following step 2 above) marking the per site 3rd-party scripts a no-op, there are still requests that get blocked, which should not happen if I understant the "All" row correctly.
Seems like the "All" row isn't getting the right importance in the blocking pipeline.
Reproduced on uBlock 0.9.9.3 and 1.0.0.0 with both Chrome and Firefox.
The text was updated successfully, but these errors were encountered: