Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force quitting firefox causes saved sessions to fail on next start #1518

Closed
kr094 opened this issue Mar 31, 2016 · 10 comments
Closed

Force quitting firefox causes saved sessions to fail on next start #1518

kr094 opened this issue Mar 31, 2016 · 10 comments

Comments

@kr094
Copy link

kr094 commented Mar 31, 2016

Force quitting firefox through windows shutdown causes the saved session to fail on next start. Tested with safe mode and exclusively with ublock enabled.

Steps to reproduce:

  1. Open any URL in firefox (I tested with youtube.com)
  2. Force quit firefox via task manager with "End Process Tree". This can also be a windows shutdown or logout
  3. Restart firefox
  4. Page showing "Whoops, this was embarrassing" and the previous session tabs are displayed

OS: Windows 7
Browser: Firefox 45.0.1
UBlock: 1.6.6 / Default filter settings

My rules:

no-popups: blank.about-scheme true
no-strict-blocking: blank.about-scheme true
no-strict-blocking: softonic.com true
no-strict-blocking: sourceforge.net true
behind-the-scene * 3p noop
behind-the-scene * 3p-frame noop

Temporary rules

no-popups: blank.about-scheme true
no-strict-blocking: blank.about-scheme true
no-strict-blocking: softonic.com true
no-strict-blocking: sourceforge.net true
behind-the-scene * 3p noop
behind-the-scene * 3p-frame noop

The blank.about rules might be the cause of this?

@gorhill
Copy link
Owner

gorhill commented Mar 31, 2016

How did you conclude this is a uBO's issue?

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

Enabling one add on at a time and re-trying my test case. I have 3 add ons:
uBO
Greasemonkey
Firebug

@gorhill
Copy link
Owner

gorhill commented Mar 31, 2016

You say

The blank.about-scheme rules might be the cause of this?

Did you try to answer your own question by trying to reproduce without these rules?

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

Yes, opening ublock on the new tab page doesn't allow me to enable/disable the power button.

@gorhill
Copy link
Owner

gorhill commented Mar 31, 2016

Alright, will do this: what you describe is a normal Firefox behavior, nothing to do with uBO. Re-open if and only if you explain very clearly what is actually wrong, along with supporting evidence that uBO is causing whatever you think is wrong.

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

I've managed to reproduce the issue already and confirmed it is with ublock. It does not happen in firefox safe mode. I've read your contributing doc and made sure to test this thoroughly

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

And it doesn't seem I can reopen github issues: isaacs/github#583

@gorhill
Copy link
Owner

gorhill commented Mar 31, 2016

You say:

Page showing "Whoops, this was embarrassing" and the previous session tabs are displayed

What are you reporting that you think is wrong? When Firefox crashes, this is actually exactly how it is supposed to behave.

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

But that behavior doesn't happen in safe mode. Nor did it happen months previously. Recently when starting firefox fresh this page is shown.

@kr094
Copy link
Author

kr094 commented Mar 31, 2016

My apologies, Raymond. I resolved the issue by following the steps listed here. https://support.mozilla.org/en-US/questions/956252

gorhill pushed a commit that referenced this issue Sep 26, 2016
el1t pushed a commit to el1t/uBlock-Safari that referenced this issue Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants