Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix logger's reverse-lookup of selectors with no
\w
characters
Related issue: - uBlockOrigin/uBlock-issues#1139
- Loading branch information
d1715fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post commit, the issue isn't fixedand now gettingerror TypeError: can't access property "reduce", selector.match(. . .) is null appears in Firefox Stable and Nightly on uBO extension console with the aformentioned repro in the issue.Edit: the same error appeared before this commit too, so no change.d1715fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have the fix, the reported line in your screenshot does not match the source code after the fix.
d1715fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, the fix is in b1 build.