Skip to content

Commit

Permalink
Raise minimum versions of browsers
Browse files Browse the repository at this point in the history
For the following reasons:

- Support for CSS `gap`, so as to remove the need to
  fall back onto classic popup panel, and thus making
  it possible to fully remove long-ago deprecated
  classic panel (announced in 1.27.0)[1]:
  https://developer.mozilla.org/en-US/docs/Web/CSS/gap

- Support for dynamic import:
  https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import

Firefox's minimum version is raised to 68 because it's
the oldest ESR version supporting the features above.
From now on, minimum version of Firefox will always be
an ESR one.

---

[1] https://github.com/gorhill/uBlock/releases/tag/1.27.0
  • Loading branch information
gorhill committed Jan 28, 2022
1 parent f98b70d commit b4911e2
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 15 deletions.
2 changes: 1 addition & 1 deletion platform/chromium/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
},
"incognito": "split",
"manifest_version": 2,
"minimum_chrome_version": "61.0",
"minimum_chrome_version": "66.0",
"name": "uBlock Origin",
"options_ui": {
"page": "dashboard.html",
Expand Down
2 changes: 1 addition & 1 deletion platform/firefox/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"browser_specific_settings": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "60.0"
"strict_min_version": "68.0"
}
},
"commands": {
Expand Down
2 changes: 1 addition & 1 deletion platform/opera/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
},
"incognito": "split",
"manifest_version": 2,
"minimum_opera_version": "48.0",
"minimum_opera_version": "53.0",
"name": "uBlock Origin",
"options_page": "dashboard.html",
"permissions": [
Expand Down
15 changes: 3 additions & 12 deletions src/js/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -487,19 +487,10 @@ contextMenu.update();
// default UI according to platform.
if (
browser.browserAction instanceof Object &&
browser.browserAction.setPopup instanceof Function
browser.browserAction.setPopup instanceof Function &&
µb.hiddenSettings.uiFlavor === 'classic'
) {
const env = vAPI.webextFlavor;
if (
µb.hiddenSettings.uiFlavor === 'classic' || (
µb.hiddenSettings.uiFlavor === 'unset' && (
env.soup.has('chromium') && env.major < 66 ||
env.soup.has('firefox') && env.major < 68
)
)
) {
browser.browserAction.setPopup({ popup: 'popup.html' });
}
browser.browserAction.setPopup({ popup: 'popup.html' });
}

// https://github.com/uBlockOrigin/uBlock-issues/issues/717
Expand Down

0 comments on commit b4911e2

Please sign in to comment.