-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Code review of IndexedDB usage for cache storage purpose
Use Promise.prototype.catch() to deal with potential exceptions. Related issue: - uBlockOrigin/uBlock-issues#416
- Loading branch information
Showing
1 changed file
with
15 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest dev build, this commit show outdated filterlists on startup only on Firefox with
cacheStorageAPI
set toindexedDB
, even though they were updated a day ago.26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox version is 67.0 if it's any help.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything in the browser console? If you use
indexedDB
and for some reasons it fails to instantiate properly, the lists will never be up to date. Usingunset
will let uBO fallback ontobrowser.storage.local
.I am using Nightly and not experiencing any issue here.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing. Empty as usual, this happens after I close the browser and run it again.
If that's considered acceptable, then I will set to unset in Firefox.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no change using unset either, situation is the same.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to the latest Nightly and browser console has this in it --
Nothing related to uBO as it seems.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, can you also look into uBO's dev console also? (you can reach uBO's dev console from
about:debugging#addons
)26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above picture is from about:debugging -> Debug for uBlock Origin.
Well, it doesn't happen if I reset to default settings, but I do have backup of my uBO configuration and if I use that to restore it, it happens.
uBO.txt
Uploaded my uBO configuration file for you to reproduce.
Anyways, I managed to fix it, I resetted back to default setting for uBO and one by one activated settings to reach my uBO configuration, restarted every time and I can't reproduce anymore, must have been corrupted cache storage or something.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be a free disk space issue? uBO's indexedDB may be evicted if free disk space reaches a threshold -- forgot exactly, maybe 1/5 of 50% free space.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox is on D drive on my Windows 10 installation with a free space of 211 GB out of 212 GB, so no that's not the issue.
I downgraded to 1.18.9rc2 and it happened there too, so something screwed up in Firefox apparently.
Can you reproduce with my uBO configuration ?
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to reproduce with your config, including after waiting for a selfie.
26c57fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not happening anymore so it's all good now.
Edit: It seems I can no longer use Restore from file functionality anymore as the issue is reproduced again with that.