Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uBlockOrigin/uBlock-issues#341 and other smaller problems #239

Merged
merged 9 commits into from
Jul 4, 2020

Conversation

hawkeye116477
Copy link
Contributor

These are mainly fixes for uBlockOrigin/uBlock-issues#341 (rules like cooking.nytimes.com##.nytc---modal-window---isShown:not(:has(.nytc---largepicturemodal---contentBody > .nytc---x---x.nytc---largepicturemodal---xBtn[role="button"]) should start working properly) and few other smaller problems. All tested on Basilisk and appears that works fine.

@JustOff
Copy link
Collaborator

JustOff commented Jun 29, 2020

Thank you very much for your efforts, everything looks good and I'm going to merge this PR after testing it in my primary working environment and receiving feedback from several active users.

I would also like to note that so far when porting from upstream I always avoided using ES6 semantics to keep browser compatibility at the same level when the legacy uBlock version was separated. Your commits violate this rule, but I think it's time to just increase the minimum supported version of the target browsers to facilitate further work on the extension and not waste time converting the upstream code to the old js syntax. This will mean that starting with the next version, the minimum requirements will be Firefox, Fennec and Thunderbird 45+, Pale Moon 28+ or SeaMonkey 2.46+.

@JustOff JustOff merged commit ac3e011 into gorhill:master Jul 4, 2020
JustOff added a commit that referenced this pull request Jul 4, 2020
@temp10min
Copy link

With this change maybe it is time to change the name to uBlock-for-firefox-XUL (or whatever is more correct) and save "legacy" for the older browsers like PM27?

@JustOff
Copy link
Collaborator

JustOff commented Jul 14, 2020

@temp10min
This was already discussed here and the answer is no.

PS: Please don't comment on merged pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants