Fix regression in the collapsing of blocked resources

Related issue: - uBlockOrigin/uBlock-issues#356 Co-authored-by: gorhill <[email protected]>
gorhill · Jun 29, 2020 · d7213bb · d7213bb
1 parent 5bac0b9
commit d7213bb
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/js/contentscript.js b/src/js/contentscript.js
@@ -767,8 +767,6 @@ vAPI.domFilterer = new vAPI.DOMFilterer();
 
 vAPI.domCollapser = (function() {
     const messaging = vAPI.messaging;
-    const toProcess = [];
-    const toFilter = [];
     const toCollapse = new Map();
     const src1stProps = {
         embed: 'src',
@@ -791,6 +789,8 @@ vAPI.domCollapser = (function() {
         cachedBlockedSet,
         cachedBlockedSetHash,
         cachedBlockedSetTimer,
+        toProcess = [],
+        toFilter = [],
         netSelectorCacheCount = 0;
 
     const cachedBlockedSetClear = function() {
@@ -881,8 +881,8 @@ vAPI.domCollapser = (function() {
             hash: cachedBlockedSetHash
         };
         messaging.send('contentscript', msg, onProcessed);
-        toProcess.length = 0;
-        toFilter.length = 0;
+        toProcess = [];
+        toFilter = [];
         resquestIdGenerator += 1;
     };
 
@@ -944,10 +944,7 @@ vAPI.domCollapser = (function() {
             return;
         }
         if ( src.lastIndexOf('http', 0) !== 0 ) { return; }
-        toFilter[toFilter.length] = {
-            type: 'sub_frame',
-            url: iframe.src
-        };
+        toFilter.push({ type: 'sub_frame', url: iframe.src });
         add(iframe);
     };