make bind work with keyword functions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 1 1
Lines 11 11
=======================================
Hits 10 10
Misses 1 1
Continue to review full report at Codecov.
|
goretkin
reviewed
Jun 17, 2020
src/Curry.jl
Outdated
| function (c::Bind)(args...) | ||
| c.f(interleave(c.a, args)...) | ||
| function (c::Bind)(args...; kw...) | ||
| c.f(interleave(c.a, args)...; c.k..., kw...) | ||
| end | ||
|
|
||
| """ | ||
| `bind(f, a, b)` is equivalent to Bind(f, (a, b)) |
There was a problem hiding this comment.
Could you amend this docstring to include a keyword arg example?
goretkin
reviewed
Jun 17, 2020
src/Curry.jl
Outdated
| @@ -83,7 +84,8 @@ bind(f, args...) = Bind(f, args) | |||
| macro bind(ex) | |||
| ex.head == :call || error() | |||
| # `ex.args[1]` is the function and `ex.args[2:end]` are the positional arguments | |||
| return :(bind($(map(esc, ex.args)...))) | |||
| TODO_HANDLE_KW = () | |||
There was a problem hiding this comment.
Does this serve the same purpose as a TODOcomment?
There was a problem hiding this comment.
yeah sorry it is a leftover from some other thing I tried.
|
Thanks for the interest and for the improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the elegant implementation in your package a lot. Here is some better keyword support.