Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support windows/arm64 #2407

Merged
merged 3 commits into from
Aug 17, 2021
Merged

feat: support windows/arm64 #2407

merged 3 commits into from
Aug 17, 2021

Conversation

caarlos0
Copy link
Member

closes #2404
closes #2405

simpler alternative to impl made in #2405. We will eventually remove those, so no need to go all fancy

closes #2404
closes #2405

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 17, 2021
@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/goreleaser/5gzqPKRaKaW1vDGJTH7pS4Bk4Cyz
✅ Preview: https://goreleaser-git-windows-arm64-goreleaser.vercel.app

@caarlos0 caarlos0 mentioned this pull request Aug 17, 2021
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@vercel vercel bot temporarily deployed to Preview August 17, 2021 01:44 Inactive
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2407 (b8e0e36) into master (d329a9c) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2407      +/-   ##
==========================================
+ Coverage   82.87%   82.99%   +0.11%     
==========================================
  Files          83       83              
  Lines        6080     6086       +6     
==========================================
+ Hits         5039     5051      +12     
+ Misses        891      886       -5     
+ Partials      150      149       -1     
Impacted Files Coverage Δ
internal/builders/golang/build.go 92.89% <100.00%> (ø)
internal/builders/golang/targets.go 100.00% <100.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d329a9c...b8e0e36. Read the comment docs.

@caarlos0 caarlos0 merged commit a813644 into master Aug 17, 2021
@caarlos0 caarlos0 deleted the windows-arm64 branch August 17, 2021 02:00
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows/arm64 support
1 participant