Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make cmd/TestInstallInNonGitRepo not affected by actual major.minor versions #1937

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

aofei
Copy link
Member

@aofei aofei commented Jul 15, 2024

This follows up on #1930.

For https://github.com/goplus/gop/actions/runs/9927782432/job/27423172805#step:4:27

=== RUN   TestInstallInNonGitRepo/install_with_VERSION_file
    make_test.go:324: Failed: exit status 2, output: panic: gop/env: [FATAL] Invalid buildVersion: v1.2.98
        
        goroutine 1 [running]:
        github.com/goplus/gop/env.initEnv()
        	/home/runner/work/gop/gop/env/version.go:47 +0x8a
        github.com/goplus/gop/env.init.0()
        	/home/runner/work/gop/gop/env/version.go:38 +0xf

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (9ff7b67) to head (a50c818).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          42       42           
  Lines       11653    11653           
=======================================
  Hits        10872    10872           
  Misses        624      624           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit 6e06287 into goplus:main Jul 15, 2024
14 checks passed
@aofei aofei deleted the make_test branch July 15, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants